Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLAYRTS-5595 Mitigate start position for DRM VODs #506

Merged

Conversation

pyby
Copy link
Member

@pyby pyby commented Jul 26, 2024

Description

Open a VOD with DRM published with the new stream packaging SRGSSR solution, like In her car - Deux soeurs - Bicanal (Episode 1/10 - Saison 1) - Play RTS or Top Models - 9263 - Play RTS (mostly all VOD with DRM in RTS Series topic).

What happened?

The playback didn’t start at the beginning, but somewhere in the stream

What should have happened?

The playback must starts at position 0.0 for VoD and AoD if no saved position in the user history (user data history).

Changes Made

  • Update SRGMediaPlayer to 7.2.3 which mitigates startup issue with malformed on-demand streams containing misaligned timestamps
    • EDIT: SRGMediaPlayer to 7.2.2 created a new playback start issue on LSVS with DRM (LA 1, LA 2, RTS 1, RTS 2). So that why 7.2.3 release is used..

Hints

Internal tests: https://srgssr-ch.atlassian.net/browse/PLAYRTS-5595

Checklist

  • I have followed the project's style guidelines.
  • I have performed a self-review of my own changes.
  • I have made corresponding changes to the documentation.
  • My changes do not generate new warnings.
  • I have tested my changes and I am confident that it works as expected and doesn't introduce any known regressions.
  • I have reviewed the contribution guidelines.

@pyby pyby added the bug Issue to be fix (issue and PR) - release notes section label Jul 26, 2024
@pyby pyby requested a review from mutaben July 26, 2024 10:09
@pyby pyby changed the title PLAYRTS-5595 Mitigate start position for DRM VOD PLAYRTS-5595 Mitigate start position for DRM VODs Jul 26, 2024
@pyby pyby marked this pull request as draft July 26, 2024 13:31
@rts-devops rts-devops temporarily deployed to playsrg-ios-nightly+PLAYRTS-5595-mitigate-start-position-for-drm-vod July 26, 2024 15:22 Inactive
@rts-devops rts-devops temporarily deployed to playsrg-tvos-nightly+PLAYRTS-5595-mitigate-start-position-for-drm-vod July 26, 2024 15:22 Inactive
@rts-devops rts-devops temporarily deployed to playsrg-tvos-nightly+PLAYRTS-5595-mitigate-start-position-for-drm-vod August 4, 2024 10:40 Inactive
@rts-devops rts-devops temporarily deployed to playsrg-ios-nightly+PLAYRTS-5595-mitigate-start-position-for-drm-vod August 4, 2024 10:40 Inactive
@pyby pyby marked this pull request as ready for review August 5, 2024 08:52
@pyby pyby added this pull request to the merge queue Aug 5, 2024
Merged via the queue into develop with commit 5085503 Aug 5, 2024
3 checks passed
@pyby pyby deleted the feature/PLAYRTS-5595-mitigate-start-position-for-drm-vod branch August 5, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue to be fix (issue and PR) - release notes section
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants